[Webkit-unassigned] [Bug 55828] [WK2] Introduce an option for no NPAPI support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55828





--- Comment #11 from Balazs Kelemen <kbalazs at webkit.org>  2011-03-24 07:01:39 PST ---
(In reply to comment #10)
> (From update of attachment 86701 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86701&action=review
> 
> > Source/WebKit2/ChangeLog:28
> > +        * WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: Added.
> 
> wouldn't NetscapePluginEmpty be a better name. That is already used for some similar case in WebKit, just search for *Empty.cpp

Let's grep!

$ find Source/ -name "*Empty*"
Source/WebCore/WebCore.gyp/mac/Empty.cpp                                                                                                    
Source/WebCore/platform/mac/EmptyProtocolDefinitions.h                                                                                      
Source/WebCore/loader/EmptyClients.h

$ find Source/ -name "*None*"
Source/JavaScriptCore/wtf/ThreadingNone.cpp
Source/WebCore/plugins/PluginDataNone.cpp
Source/WebCore/plugins/PluginViewNone.cpp
Source/WebCore/plugins/PluginPackageNone.cpp
Source/WebCore/platform/text/TextEncodingDetectorNone.cpp
Source/WebCore/platform/text/LocalizedNumberNone.cpp
Source/WebCore/platform/KillRingNone.cpp

This shows me that the name Empty is used in the context of the abstract client pattern while None is used for stubbed implementation.
This patch is fall into the second category.

> 
> > Source/WebKit2/ChangeLog:45
> > +        * config.h: Introduce PLUGIN_ARCHITECTURE(NONE) as another option.
> 
> What about UNSUPPORTED?

Good point. It's a more exact word for this case. Hopefully the mismatch between the macro name and the file name pattern is not really confusing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.