[Webkit-unassigned] [Bug 56918] [Qt] Teach build-jsc how to build JavaScriptCore on Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56918





--- Comment #2 from Andras Becsi <abecsi at webkit.org>  2011-03-24 06:08:13 PST ---
(From update of attachment 86605)
View in context: https://bugs.webkit.org/attachment.cgi?id=86605&action=review

LGTM, Just one little nitpick:

> Tools/Scripts/webkitdirs.pm:1577
> +    } else {
> +        $project = "";
> +    }

I think it would be better to use $project = 0; here and simply use !$project in the ifs, this would make the paths easier to read.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.