[Webkit-unassigned] [Bug 56586] Media Stream API: add the getUserMedia method and the Javascript bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56586





--- Comment #28 from Steve Block <steveblock at google.com>  2011-03-24 04:40:27 PST ---
(From update of attachment 86676)
View in context: https://bugs.webkit.org/attachment.cgi?id=86676&action=review

I think we can avoid the need for any custom callbacks. See Bug 40065.

Also, you should add some tests for the bindings. See LayoutTests/fast/dom/Geolocation/enabled.html and LayoutTests/fast/dom/Geolocation/argument-types.html for example.

> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:50
> +    // FIXME: This check disallows callable objects created via JSC API. It's not clear what exactly the specification intends to allow.

A FIXME is OK here for now, but add a link to https://bugs.webkit.org/show_bug.cgi?id=40012

> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:62
> +    // Argument is optional (hence undefined is allowed), and null is allowed.

Are you sure that null is allowed? I don't see this in the spec.

> Source/WebCore/page/NavigatorUserMediaError.idl:33
> +    // FIXME: delete this interface and implement a custom binding since spec defines it as a NoInterfaceObject.

I don't think that it being marked NoInterfaceObject means that it needs to have custom bindings. It just means that the constructor object shouldn't appear on the global object. You should add a test for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.