[Webkit-unassigned] [Bug 56885] WebFrame::createAssociatedURLLoader can't accept WebURLLoaderOptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56885


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86648|review?                     |review-
               Flag|                            |




--- Comment #10 from Dmitry Titov <dimich at chromium.org>  2011-03-23 18:24:27 PST ---
(From update of attachment 86648)
View in context: https://bugs.webkit.org/attachment.cgi?id=86648&action=review

Almost there. just a few tiny things.

> Source/WebKit/chromium/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=56885

This ChangeLog is not informative. It is obvious that the patch adds a parameter. Good ChangeLog entry tells why (as you did in the bug itself).

> Source/WebKit/chromium/public/WebFrame.h:350
> +    virtual WebURLLoader* createAssociatedURLLoader() = 0;

/FIXME/FIXME:/

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1055
> +// FIXME Remove this overload when clients have been changed to pass options.

/FIXME/FIXME:/

> Source/WebKit/chromium/src/WebFrameImpl.h:136
> +    // FIXME Remove this overload when clients have been changed to pass options.

/FIXME/FIXME:/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.