[Webkit-unassigned] [Bug 56885] WebFrame::createAssociatedURLLoader can't accept WebURLLoaderOptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56885





--- Comment #6 from David Levin <levin at chromium.org>  2011-03-23 13:35:50 PST ---
(In reply to comment #5)
> Created an attachment (id=86648)
 --> (https://bugs.webkit.org/attachment.cgi?id=86648&action=review) [details]
> Proposed Patch
> 
> Ack. Still learning your ways.

May I humbly suggest an appropriate penance would be to fix our style checking tool to catch this automatically? :)

It shouldn't be too hard even if you don't know python. I'd be happy to give you pointers/help with doing this. (The code is in Tools/Scripts/webkitpy/style/checkers/cpp.py and I suspect we'd need code similar to where we check for 2 spaces after a period in comments -- as a note to myself that occurs where there is a comment "    # Next, we check for proper spacing with respect to comments.").

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.