[Webkit-unassigned] [Bug 56586] Media Stream API: add the getUserMedia method and the Javascript bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56586





--- Comment #25 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-03-23 12:22:26 PST ---
(From update of attachment 86616)
View in context: https://bugs.webkit.org/attachment.cgi?id=86616&action=review

>> Source/WebCore/page/CallbackTask.h:43
>> +// Auxiliar template to schedule calls to callbacks using their own script execution context.
> 
> 'Auxiliary' or just 'Helper'

Fixed.

>> Source/WebCore/page/CallbackTask.h:73
>> +        , m_data(adoptRef(data))
> 
> Why are you calling adoptRef() here? adoptRef() is intended for use when an object is first created with 'new'. See http://www.webkit.org/coding/RefPtr.html

Fixed. Was part of a temporary fix to avoid cycles while including.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.