[Webkit-unassigned] [Bug 56586] Media Stream API: add the getUserMedia method and the Javascript bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56586





--- Comment #22 from Steve Block <steveblock at google.com>  2011-03-23 11:50:34 PST ---
(From update of attachment 86616)
View in context: https://bugs.webkit.org/attachment.cgi?id=86616&action=review

first couple of comments ...

> Source/WebCore/page/CallbackTask.h:43
> +// Auxiliar template to schedule calls to callbacks using their own script execution context.

'Auxiliary' or just 'Helper'

> Source/WebCore/page/CallbackTask.h:73
> +        , m_data(adoptRef(data))

Why are you calling adoptRef() here? adoptRef() is intended for use when an object is first created with 'new'. See http://www.webkit.org/coding/RefPtr.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.