[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 09:54:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55571





--- Comment #30 from Jia Pu <jpu at apple.com>  2011-03-23 09:54:51 PST ---
(From update of attachment 86423)
View in context: https://bugs.webkit.org/attachment.cgi?id=86423&action=review

>> Source/WebCore/editing/SpellingCorrectionController.cpp:186
>> +    RefPtr<Range> correctionStartOffsetInParagraphAsRange = Range::create(paragraphRangeContainingCorrection->startContainer(ec)->document(), paragraphRangeContainingCorrection->startPosition(), paragraphRangeContainingCorrection->startPosition());
> 
> Wow! this is a really long statement.  Maybe the variable name is too verbose.

Huh, now looking back at the code myself, it seems we could shed the "ContainingCorrection" part from "paragraphRangeContainingCorrection".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list