[Webkit-unassigned] [Bug 56829] REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56829





--- Comment #14 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-23 08:28:16 PST ---
(From update of attachment 86539)
View in context: https://bugs.webkit.org/attachment.cgi?id=86539&action=review

> Source/WebCore/platform/Length.h:143
> +                    // do not try to optimize this. It will cause incorrect rounding on 32-bit intel machines that use the FPU
> +                    float retVal = maxValue * percent() / 100.0f;
> +                    return static_cast<int>(retVal);

I don't think this comment is clear enough. "optimize" could have many different interpretations. Explicitly saying "Don't remove the local float variable" would be more helpful.

The first word of the comment should be capitalized, as should "Intel".

It is very surprising that a float local fixes the problem. I assume appending "f" to 100.0 wasn't enough?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.