[Webkit-unassigned] [Bug 56861] [Qt] RSS Feed MIME type handling in QtWebkit

Wed Mar 23 07:03:18 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56861

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86511|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2011-03-23 07:03:18 PST ---
(From update of attachment 86511)
View in context: https://bugs.webkit.org/attachment.cgi?id=86511&action=review

The changelog is supposed to describe the change. You are not supposed to put the full context as in the bug description.

There is no test, no reason given for that.

The change looks invalid anyway. The mimetypes text/xml and application/xml are perfectly valide types for WebKit.

> Source/WebCore/ChangeLog:5
> +        For QT based Webkit, the handling of RSS MIME type content 

Qt is spelled "Qt", uppercase Q, lowercase t.

> Source/WebCore/ChangeLog:7
> +        screen.  For the Symbian/QT based Browser to subscribe to a

QT->Qt

> Source/WebCore/ChangeLog:14
> +        Does not require test cases. 

Why is that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.