[Webkit-unassigned] [Bug 56818] Spellcheck feature specific symbol should be defined.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 22:04:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56818





--- Comment #5 from Kent Tamura <tkent at chromium.org>  2011-03-22 22:04:47 PST ---
(From update of attachment 86568)
View in context: https://bugs.webkit.org/attachment.cgi?id=86568&action=review

> Source/JavaScriptCore/wtf/Platform.h:1148
> +/* Text checking and editing */
> +#if !defined(BUILDING_ON_TIGER)
> +#define WTF_USE_GRAMMAR_CHECKING 1
> +#endif
> +
> +#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> +#define WTF_USE_UNIFIED_TEXT_CHECKING 1
> +#define WTF_USE_AUTOMATIC_TEXT_REPLACEMENT 1
> +#endif

I think it's ok to define WTF_USE_* symbols in TextCheckerClient.h like the previous patch.
We have some instances defining WTF_USE_* not in Platform.h, like WebCore/platform/graphics/ImageBuffer.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list