[Webkit-unassigned] [Bug 56888] New: webkit-patch doesn't work right in the default gclient-based chromium checkout of webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56888

           Summary: webkit-patch doesn't work right in the default
                    gclient-based chromium checkout of webkit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: eric at webkit.org, abarth at webkit.org


Because Chromium attempts to be "smart" when it checks out webkit using gclient, we only check out sub directories of webkit we need to compile rather than the whole tree. Unfortunately, this has the effect of creating multiple SVN repositories, and scm.checkout_root gets pointed at things other than the top of the tree (e.g., WebKit/Source, WebKit/Tools, etc. rather than just WebKit/). This causes most of the Executive calls to try and spawn things in the wrong location and you get weird errors as a result.

We should probably be using a method that hangs off of a Port object (like NRWT does) or at least something hanging off of a Checkout object rather than using scm.default_scm() or scm.find_checkout_root().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.