[Webkit-unassigned] [Bug 56692] Add high-quality band-limited audio resampling algorithm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56692


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86490|review?                     |review+
               Flag|                            |




--- Comment #6 from Kenneth Russell <kbr at google.com>  2011-03-22 13:13:48 PST ---
(From update of attachment 86490)
View in context: https://bugs.webkit.org/attachment.cgi?id=86490&action=review

Looks better, thanks. Couple of additional minor issues you can fix upon landing.

> Source/WebCore/platform/audio/SincResampler.cpp:165
> +    while (numberOfDestinationFrames > 0) {

numberOfDestinationFrames is unsigned, so this test is not well written. Would be better as "while (numberOfDestinationFrames)".

> Source/WebCore/platform/audio/SincResampler.cpp:316
> +            numberOfDestinationFrames--;

In WebKit, prefer predecrement (--numberOfDestinationFrames).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.