[Webkit-unassigned] [Bug 56424] add beforeload to icon and prefetch link rel types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56424





--- Comment #3 from Tony Gentilcore <tonyg at chromium.org>  2011-03-22 12:01:58 PST ---
(From update of attachment 85930)
View in context: https://bugs.webkit.org/attachment.cgi?id=85930&action=review

> LayoutTests/fast/dom/HTMLLinkElement/prefetch-beforeload.html:12
> +}

It would be best to skip implementing a print() method and instead include <script src="../js/resources/js-test-pre.js"></script> and use testPassed()/testFailed(). Ditto in the other tests.

> LayoutTests/platform/chromium-mac/webarchive/test-link-rel-icon-beforeload-expected.txt:1
> +CONSOLE MESSAGE: line 8: Uncaught TypeError: Object [object Object] has no method 'dumpDOMAsWebArchive'

It is kind of unfortunate to need a pixel test for this behavior. Is there any particular reason why a webarchive test is needed to test a <link rel=icon> w/ a beforeload?

> Source/WebCore/html/HTMLLinkElement.cpp:196
> +bool HTMLLinkElement::checkBeforeLoadEvent()

Thanks for extracting this logic. This dance is non-obvious and failure to perform it properly has caused several bugs. The same code is in ScriptElement.cpp and might need to be in other places where these extra checks aren't performed. Is it possible to move it up to dispatchBeforeLoadEvent() or have another shared helper method to avoid the duplication? Or perhaps that should be a separate patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.