[Webkit-unassigned] [Bug 56425] WebKit2 Icon Database
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 22 10:40:52 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=56425
--- Comment #21 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-03-22 10:40:52 PST ---
Attachment 86475 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/UIProcess/WebIconDatabaseImpl.h:41: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.h:68: Missing space before { [whitespace/braces] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1: Should have a space between // and comment [whitespace/comments] [4]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:16: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:62: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:331: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:445: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:505: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:554: Semicolon defining empty statement for this loop. Use { } instead. [whitespace/semicolon] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:611: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:684: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:718: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:902: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:949: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:986: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1195: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1320: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1405: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1525: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebIconDatabaseImpl.cpp:1526: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebKit2/UIProcess/WebContext.h:159: The parameter name "path" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 21 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list