[Webkit-unassigned] [Bug 53747] Add some dynamic annotations to JavaScriptCore/wtf

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53747


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #47 from Alexey Proskuryakov <ap at webkit.org>  2011-03-22 10:37:43 PST ---
> Do you think it's worth changing to C++? 

Yes. Keeping it as C would be an exception, and let's not make an exception if that's not required.

> Mark pointed out that the annotations may be unreadable for non-experts.
> This is one of the reasons to keep at least *some* comments.

If one sees a mysterious WTF_ANNOTATE_HAPPENS_BEFORE macro, they should jump to definition and read a comment there. A comment at call site can explain why we need it here in particular, not what it is.

I don't think that an external link is a particularly good thing to have in WebKit sources, but it's OK.

> and call HAPPENS_AFTER(&ref) before calling free()/operator delete.

OK. The "before"/"after" names are pretty misleading then - you need to call "before" before doing something, but you don't need to call "after" after doing that - instead, you call it before doing something else.

> How can I do that?
> Is there an automated tool to do that?

There is no automated tool to add forwarding headers. You just need to build on Mac, and add necessary headers in each project complaining that it can't find them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.