[Webkit-unassigned] [Bug 55929] [GTK] Add proxy support to GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55929


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85045|review?                     |review-
               Flag|                            |




--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org>  2011-03-22 08:59:24 PST ---
(From update of attachment 85045)
View in context: https://bugs.webkit.org/attachment.cgi?id=85045&action=review

This patch does too many things in one go, going way beyong 'adding proxy support' - it would at least need to be broken up in two or three patches that each do its thing. I also don't like the idea of reinventing argument parsing inside GtkLauncher.  So, to be clear:

1. If we want proxy support, I am OK with using the new default proxy resolver included in libsoup: https://bugzilla.gnome.org/show_bug.cgi?id=642928
2. I'm fine with options to request different width/height, but that should be a separate patch and use glib's option parsing infrastructure, no manual arguments parsing
3. The changes to how webkit_web_view_load_uri is apparently gain us nothing while removing the ability to give GtkLauncher a filename

> Tools/GtkLauncher/main.c:359
> -    gchar *uri =(gchar*)(argc > 1 ? argv[1] : "http://www.google.com/");
> -    gchar *fileURL = filenameToURL(uri);
> -
> -    webkit_web_view_load_uri(webView, fileURL ? fileURL : uri);
> -    g_free(fileURL);
> +    webkit_web_view_load_uri(webView, uri);

This seems to be totally unrelated?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.