[Webkit-unassigned] [Bug 38696] Unfocused contenteditable element still receives keyboard events and gets modified

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38696


Levi Weintraub <leviw at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86432|review?                     |
               Flag|                            |




--- Comment #9 from Levi Weintraub <leviw at chromium.org>  2011-03-22 08:00:00 PST ---
(From update of attachment 86432)
Removing the r? as there's still some things to be done here... mainly unifying the expression in Editor.cpp with the code in setFocusedNodeIfNeeded to use some function like focusableRoot.

This change incorporates a fix for 56271, as they both have to do with selection and focus being bound together differently than in other browsers, and both result in many rebaselines. This change, however, is risky. Sites that do a lot of fancy editing and selection that may have WebKit-specific paths could break. Ideally I'd like to see the final version of this patch put into a Chrome Dev-channel release to get some widespread exposure and identify possible site breakage.

Thoughts and comments are appreciated, and keep in mind this doesn't include the couple hundred rebaselines due to changes in focus ring rects and editing delegates.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.