[Webkit-unassigned] [Bug 56826] [Qt] Implement fullscreen playback for the GStreamer backend.

Tue Mar 22 06:39:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56826

Alexis Menard <alexis.menard at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |alexis.menard at openbossa.org
                   |kit.org                     |
  Attachment #86457|                            |review?, commit-queue?
               Flag|                            |

--- Comment #1 from Alexis Menard <alexis.menard at openbossa.org>  2011-03-22 06:39:09 PST ---
Created an attachment (id=86457)
 --> (https://bugs.webkit.org/attachment.cgi?id=86457&action=review)
Proposed patch.

This patch implement the support in FullScreenVideoQt alongside with the Qt Multimedia support. I though about reusing the base class QWebFullScreenVideoHandler of the platform plugin but it required to change the interface of the plugin and the show(QMediaPlayer*) was also an issue (and I found very ugly to have a plugin interface with some ifdef inside). The #if defined(WTF_USE_GSTREAMER) && WTF_USE_GSTREAMER is for moc to compile the class definition (moc does not expand the USE macro). Any feedback?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.