[Webkit-unassigned] [Bug 54138] [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54138


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86288|review?                     |review-
               Flag|                            |




--- Comment #17 from Benjamin Poulain <benjamin at webkit.org>  2011-03-22 06:27:48 PST ---
(From update of attachment 86288)
View in context: https://bugs.webkit.org/attachment.cgi?id=86288&action=review

The change make sense to me, I would just like better testing.

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2482
> +void tst_QWebPage::webGLScreenshotWithoutView()

I would like this test, with and without AcceleratedCompositingEnabled. Just to have good coverage.

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2484
> +    QWebPage* page = new QWebPage;

You should allocate the QWebPage on the stack to avoid dealing with the memory manually.

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2492
> +    ::waitForSignal(mainFrame, SIGNAL(loadFinished(bool)), 2000);

Is loadFinished() called for setHtml? Otherwise the test would always spend 2 seconds waiting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.