[Webkit-unassigned] [Bug 56824] [Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4

Tue Mar 22 06:11:27 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56824

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86455|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2011-03-22 06:11:27 PST ---
(From update of attachment 86455)
View in context: https://bugs.webkit.org/attachment.cgi?id=86455&action=review

> Source/WebCore/ChangeLog:10
> +

I would prefer you mention the test you are fixing with this patch in the changelog. Just so it is explicit how this change is tested.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1099
> +#if !defined (QT_OPENGL_ES_2)

We usually do not put space between defined and the parenthesis.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1100
> +    if (internalformat == RGBA4 || internalformat == RGB565 || internalformat == RGB5_A1)

What about DEPTH_STENCIL and DEPTH_COMPONENT16? (just saw those have special case in GraphicsContext3DOpenGL).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.