[Webkit-unassigned] [Bug 56752] [QT] Overlap of selection lists on www.travelocity.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56752


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86354|commit-queue?               |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2011-03-22 05:42:11 PST ---
(From update of attachment 86354)
View in context: https://bugs.webkit.org/attachment.cgi?id=86354&action=review

R- because:
-change not justified. You do not explain why your code is correct, you just said it fixes a particular website
-no tests

Note that you forgot the review flag.

> Source/WebCore/ChangeLog:12
> +	https://bugs.webkit.org/show_bug.cgi?id=56752
> +
> +	The method RenderThemeQt::minimumMenuListSize returns a width that too wide for
> +	each character. This leaves extra spaces in a selection list and makes
> +	selection lists overlap each other in web pages.
> +
> +	Change minimumMenuListSize to return the size (fm.width*1) instead of (fm.witdh*7).

Indent is wrong.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:437
> +    return 1 * fm.width(QLatin1Char('x'));

You could just return fm.width(QLatin1Char('x'));, the "1 * " does not add clarity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.