[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 21:37:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55571





--- Comment #23 from MORITA Hajime <morrita at google.com>  2011-03-21 21:37:48 PST ---
> I'm still not happy about the fact all these member functions will be linked in non-Lion WebKit even though they're never called in practice because they are referenced in Editor.cpp.  You should really consider adding EmptySpellingCorrectionController or come up with a clever solution to avoid this.

Well, I just returned back to the if/endif way. 
Instead of scattering if/endif blocks, This change embrace all codebase in single block 
at SpellingCorrectionController.cpp , and put empty implementations into the else/endif part.
I gave up EmptySpellingCorrectionController because runtime polymorphism doesn't help us 
from build breakages unless the alternative code path is compiled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list