[Webkit-unassigned] [Bug 56787] Expose "webkitIndexedDB" to Workers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56787


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86394|review-                     |review?
               Flag|                            |




--- Comment #3 from Jeremy Orlow <jorlow at chromium.org>  2011-03-21 17:43:07 PST ---
(From update of attachment 86394)
View in context: https://bugs.webkit.org/attachment.cgi?id=86394&action=review

> LayoutTests/storage/indexeddb/basics-workers.js:11
> +    shouldBeTrue("'webkitIndexedDB' in window");

I don't get it...you set window = self above (in some cases)...?  What exactly is this testing?

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

what about the above test?

Eventually, all indexedDB tests shoudl run against workers and the main window.  It's OK to just do a few for now tho.

> Source/WebCore/workers/WorkerContext.h:206
> +

extra new line

> Source/WebCore/workers/WorkerContext.idl:139
> +

extra newline

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.