[Webkit-unassigned] [Bug 56770] Speed up HitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56770





--- Comment #11 from Geoff Pike <gpike at chromium.org>  2011-03-21 17:06:07 PST ---
Thanks for the review!

> > Source/WebCore/rendering/HitTestResult.h:123
> > +    const NodeSet& rectBasedTestResult() { return getOrCreateNodeSet(); }
> 
> The old function was const, but your new function is not. But it should be.

I considered that option but was concerned about thread safety. If a
method is const then I would expect it to be safe to call without
locking. If I take your suggestion should I also add an
explanatory comment?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.