[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55644





--- Comment #20 from Adam Klein <adamk at chromium.org>  2011-03-21 16:41:40 PST ---
(From update of attachment 86248)
View in context: https://bugs.webkit.org/attachment.cgi?id=86248&action=review

>> Source/WebCore/fileapi/LocalFileSystem.h:57
>> +    void readFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type, PassOwnPtr<AsyncFileSystemCallbacks>, bool synchronous = false);
> 
> Why add this parameter and then ignore it?

The code in fileapi/LocalFileSystem.cpp is a stubbed-out implementation that's not currently used since the Chromium port is the only one to implement FileSystem.  My code's ignoring of the new parameter is just following in the footsteps of requestFileSystem, in this same file.  Note that I do use the bool in LocalFileSystemChromium.cpp.

Kinuko may be able to explain why this stubbed impl exists at all; it seems that things would work just fine without it.

>> Source/WebCore/workers/WorkerContext.h:136
>> +        void resolveLocalFileSystemURL(const String& url, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);
> 
> The parameter name successCallback would add information in this case so it would be good to add it.

Added the name here, and above for requestFileSystem for consistency.

>> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:67
>> +void openFileSystemHelper(ScriptExecutionContext* context, AsyncFileSystem::Type type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks, bool synchronous, long long size, CreationFlag create)
> 
> Function local to file should be "static".

Function was already inside an anonymous namespace, but I've moved the namespace up to cover only the enum, and made the function static.  Let me know if you want the function inside the namespace, but that seems redundant to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.