[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

Mon Mar 21 15:58:41 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=55644

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86248|review?                     |review-
               Flag|                            |

--- Comment #18 from David Levin <levin at chromium.org>  2011-03-21 15:58:41 PST ---
(From update of attachment 86248)
View in context: https://bugs.webkit.org/attachment.cgi?id=86248&action=review

Just a few minor things to address.

> Source/WebCore/fileapi/LocalFileSystem.h:57
> +    void readFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type, PassOwnPtr<AsyncFileSystemCallbacks>, bool synchronous = false);

Why add this parameter and then ignore it?

> Source/WebCore/workers/WorkerContext.h:136
> +        void resolveLocalFileSystemURL(const String& url, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

The parameter name successCallback would add information in this case so it would be good to add it.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:67
> +void openFileSystemHelper(ScriptExecutionContext* context, AsyncFileSystem::Type type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks, bool synchronous, long long size, CreationFlag create)

Function local to file should be "static".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.