[Webkit-unassigned] [Bug 56758] percentages are incorrectly rounded in WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 11:40:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56758





--- Comment #2 from Rik Cabanier <cabanier at adobe.com>  2011-03-21 11:40:18 PST ---
>From Simon's review:
>> Source/WebCore/rendering/AutoTableLayout.cpp:235
>> +    const float epsilon = 1 / 128.0f;
> It's not obvious why you chose 1/128 here.

I did it to keep the existing behavior intact. Percentages used to be fixed point and epsilon was set to 1 which is 1/128 of a percentage point.

The whole 'epsilon' logic is flawed and should probably be removed...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list