[Webkit-unassigned] [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56200





--- Comment #6 from Christian Dywan <christian at twotoasts.de>  2011-03-21 10:35:00 PST ---
(In reply to comment #4)
> Created an attachment (id=86328)
 --> (https://bugs.webkit.org/attachment.cgi?id=86328&action=review) [details]
> Patch

An undesirable side effect of the patch is that the icon database is not shared by default, ie. the current behavior is to use the same database path unless explicitly overridden.

One idea: add a webkit_icon_database_get_default_path().

Another idea: don't cleanup by default, so the app can retain pages and allow cleanup when it makes sense. So it would be reduced from


_delay_database_cleanup
_set_path
_retain_icon_for_uri
_allow_database_cleanup

to

_retain_icon_for_uri
_allow_database_cleanup

Btw I think the "database" in the method name is redundant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.