[Webkit-unassigned] [Bug 56458] Media Streaming API patch 0: adding compilation guards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56458





--- Comment #17 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-03-21 08:44:26 PST ---
(From update of attachment 86174)
View in context: https://bugs.webkit.org/attachment.cgi?id=86174&action=review

>> Source/WebCore/features.pri:78
>> +!contains(DEFINES, ENABLE_MEDIA_STREAM=.): DEFINES += ENABLE_MEDIA_STREAM=0
> 
> Is this change required to make build-webkit work for Chromium?

No, you're right. I'm removing this.

>> Tools/Scripts/build-webkit:264
>> +      define => "ENABLE_MEDIA_STREAM", default => isChromium(), value => \$mediaStreamSupport },
> 
> Presumably there'll be a runtime flag for Chromium too to prevent the feature from being accessible while still only partially complete?

Yes, you're right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.