[Webkit-unassigned] [Bug 56708] Web Inspector: make frameId in network agent of type string, not unsigned long.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56708


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86259|review?                     |review+
               Flag|                            |




--- Comment #6 from Yury Semikhatsky <yurys at chromium.org>  2011-03-21 00:28:16 PST ---
(From update of attachment 86259)
View in context: https://bugs.webkit.org/attachment.cgi?id=86259&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:236
> +    unsigned long long address = reinterpret_cast<uintptr_t>(pointer);

does unsigned long long always fit pointer type?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:238
> +    return String::format("%.0llX", address);

We should use a map address->id to enumerate all iframes instead of exposing raw address over the protocol.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.