[Webkit-unassigned] [Bug 56681] Web Inspector: expose object id as string, not JSON struct in the protocol.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56681





--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2011-03-21 00:16:37 PST ---
(From update of attachment 86257)
View in context: https://bugs.webkit.org/attachment.cgi?id=86257&action=review

> LayoutTests/http/tests/inspector/protocol-test.js:5
> +    if (object instanceof Object)

Consider renaming object to value. object sounds like an instance of Object while the parameter can take integer values.

> Source/WebCore/inspector/InjectedScriptManager.cpp:83
> +        bool success = parsedObjectId->asObject()->getNumber("injectedScriptId", &injectedScriptId);

Now that objectId is an opaque string for the front-end we can switch to a more compact format, probably two numbers separated by a column.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.