[Webkit-unassigned] [Bug 56103] [WK2] Handle keyboard and mouse events on X11

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56103





--- Comment #5 from Andreas Kling <kling at webkit.org>  2011-03-18 11:52:10 PST ---
(From update of attachment 85342)
View in context: https://bugs.webkit.org/attachment.cgi?id=85342&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:261
> +    return timestampInSeconds * 1000.0;

Coding style, superfluous .0 suffix.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:351
> +// We undefine these constants in npruntime_internal.h to avoid collosion

Typo, collision.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:356
> +const int kKeyPressType = 2;
> +const int kKeyReleaseType = 3;
> +const int kFocusInType = 9;
> +const int kFocusOutType = 10;

Not a huge fan of these. Guess it's unavoidable though.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:415
> +    ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::KeyUp); // We don't generate other types.

Are you sure we don't generate other types?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.