[Webkit-unassigned] [Bug 56055] Hook up new AppKit autocorrection UI with WK2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56055


Jia Pu <jpu at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #3 from Jia Pu <jpu at apple.com>  2011-03-18 10:15:51 PST ---
(In reply to comment #2)
> (From update of attachment 85249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85249&action=review
> 
> > Source/WebKit/mac/WebCoreSupport/CorrectionPanelMac.h:48
> > +    void doDismiss(WebCore::ReasonForDismissingCorrectionPanel, bool dismissingExternally);
> 
> Not a great name for this function. It’s unclear how dismiss is different from doDismiss.
> 

doDismiss() contains the actual implementation, but shall not be called directly. It's used by both dismiss() and two other public functions().

dismiss() is public function which always pass false as second argument to doDismiss().

I'm not sure what kind of naming convention WebKit uses in situation like this. Maybe just use the same name?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.