[Webkit-unassigned] [Bug 56294] Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.

Fri Mar 18 09:40:11 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56294

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86170|review?                     |review+
               Flag|                            |

--- Comment #16 from Yury Semikhatsky <yurys at chromium.org>  2011-03-18 09:40:11 PST ---
(From update of attachment 86170)
View in context: https://bugs.webkit.org/attachment.cgi?id=86170&action=review

> Source/WebCore/inspector/generate-inspector-idl:36
> +    # Python 3, change to: print("Usage: %s -o OUTPUT_FILE INPUT_FILE" % program_name, file=sys.stderr)

Remove this confusing comment.

> Source/WebCore/inspector/generate-inspector-idl:106
> +        output_file.write("\n#if defined(ENABLE_%s) && ENABLE_%s" % (macro_traits[domain["domain"]], macro_traits[domain["domain"]]))

Please extract macro_traits[domain["domain"]] int a variable. It's repeated 4 times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.