[Webkit-unassigned] [Bug 56624] [CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 18 04:05:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56624





--- Comment #7 from Ryuan Choi <ryuan.choi at samsung.com>  2011-03-18 04:05:13 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Please give this file "*.cmake" extension. The different txt files is a ugly hack at the moment, which should be removed in the future.
> > 
> > Thanks, I changed CMakeListsJSC.txt to CMakeListsJSC.cmake.
> 
> Sorry for my short comment: I'd prefer UseJSC.cmake, corresponding to USE(JSC).
> IMHO the V8 part should be named UseV8.cmake.

No problem, I updated.

> 
> BTW: I think PlatformEFL.cmake and PlatformWinCE.cmake would be better compared to CMakeListsEFL.txt and CMakeListsWinCE.txt.

It looks no problem just for me.
If other guys have no objection, I will prepare it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list