[Webkit-unassigned] [Bug 56555] [Qt] Enable GraphicsContext3D only when the window surface support OpenGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56555


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86138|review?                     |review+
               Flag|                            |




--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-18 02:00:18 PST ---
(From update of attachment 86138)
View in context: https://bugs.webkit.org/attachment.cgi?id=86138&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:469
> +    QWebPageClient* webPageClient = m_hostWindow->platformPageClient();
> +
> +    QAbstractScrollArea* scrollArea = qobject_cast<QAbstractScrollArea*>(webPageClient->ownerWidget());

I would remove that unneeded newline

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:472
> +    if (scrollArea)
> +        return qobject_cast<QGLWidget*>(scrollArea->viewport());

Doesn't casting 0 return a 0? Just wondered if you could do "return qobject..."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.