[Webkit-unassigned] [Bug 56076] rebaseline-chromium-webkit-tests should ignore reftests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56076





--- Comment #12 from Hayato Ito <hayato at chromium.org>  2011-03-17 22:00:34 PST ---
(From update of attachment 86025)
Hi Tony, thank you for the review.

I'll submit the patch after I fix the following minor points.

View in context: https://bugs.webkit.org/attachment.cgi?id=86025&action=review

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:242
>> +          False if reftests are wrongly marked as 'needs rebaseliing' or True
> 
> rebaseliing -> rebaselining

Done

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:257
>> +                self._rebaselining_tests = []
> 
> Nit: Should this be set()?  Maybe __init__ should use set() too.

Done. I'll also fix __init__.

It looks the current code doesn't assume self._rebaselining_tests must be 'set'. It seems that it must be 'iteratable' (list, set and so on).
To be consistent with the return value of self._test_expectatations.get_rebaselining_failures(), 'set' is better here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.