[Webkit-unassigned] [Bug 56598] [chromium] Video colors have wrong brightness/contrast

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56598





--- Comment #7 from Vangelis Kokkevis <vangelis at chromium.org>  2011-03-17 16:27:04 PST ---
(In reply to comment #6)
> (From update of attachment 86101 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86101&action=review
> 
> > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:63
> > +const float VideoLayerChromium::yuvAdjust[3] = {
> 
> Since these values are fixed, why not put them straight in the shader?  I guess the same would apply for the conversion matrix too!

Never mind.  Ken reminded me about the comman vs period issue which resulted in these being passed as uniforms...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.