[Webkit-unassigned] [Bug 56590] New: Rename setMarkedText to setMarkedTextAndSelectionWithin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 14:08:23 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56590

           Summary: Rename setMarkedText to
                    setMarkedTextAndSelectionWithin
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: ap at webkit.org


In the discussion on IRC, we came to conclusion that setMarkedText is a confusing function because it sets marked text and also selection within the marked text.  This confusion resulted in an incorrect layout test change in http://trac.webkit.org/changeset/80064.

We should rename this function to setMarkedTextAndSelectionWithin so that we don't make similar mistakes in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list