[Webkit-unassigned] [Bug 54929] REGRESSION: Text selection broken for text with line-height applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54929





--- Comment #12 from Levi Weintraub <leviw at chromium.org>  2011-03-17 13:20:36 PST ---
(In reply to comment #11)
> -        IntPoint point(pointInLogicalContents.x(), closestBox->logicalTop());
> +        IntPoint point(pointInLogicalContents.x(), closestBox->isText() ? closestBox->root()->selectionTop() : closestBox->logicalHeight());
> 
> Why not pass selectionTop() in all cases?
> 
> RenderReplaced::positionForPoint(const IntPoint& point)
> 
> assumes that anything above selectionTop() is above it also, for example. Not sure about the others...

I agree, it's weird, and that was originally the patch I tried. However, this broke for input elements, which would behave exactly like the attached test case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.