[Webkit-unassigned] [Bug 54929] REGRESSION: Text selection broken for text with line-height applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54929





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-17 12:08:02 PST ---
(From update of attachment 85560)
View in context: https://bugs.webkit.org/attachment.cgi?id=85560&action=review

I can't review this patch since I'm not familiar with rendering engine but I'll comment on some nits in the tests.

> LayoutTests/editing/selection/selecting-text-with-height-exceeding-line-height.html:3
> +<div id="description">This tests selection of text boxes that exceed their line height. To test this manually, start dragging in the text below and drag right (not down) past the end of the content. The selection should contain the end of the content.</div>

I think you should check condition in script (just dump window.getSelection().toString()) so that you can print PASS/FAIL.  That way, you don't even have to include those editing delegate dumps.

> LayoutTests/editing/selection/selecting-text-with-height-exceeding-line-height.html:10
> +function runTest() {
> +    if (!window.layoutTestController)
> +        return;

I don't think you need to put your test in this function.  You can just do:

if (window.layoutTestController) {
...
}

> LayoutTests/editing/selection/selecting-text-with-height-exceeding-line-height.html:13
> +    window.layoutTestController.dumpEditingCallbacks();
> +    window.layoutTestController.dumpAsText();

You don't need "window."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.