[Webkit-unassigned] [Bug 56494] Uninitialized variable "useFallback" in WebCore/loader/SubframeLoader.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 11:16:44 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56494





--- Comment #3 from Nate Chapin <japhet at chromium.org>  2011-03-17 11:16:44 PST ---
(From update of attachment 85989)
I just checked the revision logs, looks like this is an old bug that I moved from FrameLoader to SubframeLoader while refactoring.  Sorry for not catching it then :(

We should probably ensure that shouldUsePlugin() sets useFallback on all paths.  It looks like the early exit at http://trac.webkit.org/browser/trunk/Source/WebCore/loader/SubframeLoader.cpp?rev=77752#L305 is the only problem, and I think that should be 
'useFallback = false;'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list