[Webkit-unassigned] [Bug 56555] [Qt] Enable GraphicsContext3D only when the window surface support OpenGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56555


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86062|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #10 from Benjamin Poulain <benjamin at webkit.org>  2011-03-17 09:41:11 PST ---
(From update of attachment 86062)
View in context: https://bugs.webkit.org/attachment.cgi?id=86062&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:474
> +    PageClientQWidget* webPageClient
> +        = static_cast<PageClientQWidget*>(m_hostWindow->platformPageClient());

This should be on one line.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:488
> +    PageClientQWidget* webPageClient
> +        = static_cast<PageClientQWidget*>(m_hostWindow->platformPageClient());

This should be on one line.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:504
> +    QGLWidget* viewportGLWidget = getViewportGLWidget();
> +    if (testAcceleratedCompositing()
> +            && viewportGLWidget
> +            && viewportGLWidget == m_viewportGLWidget
> +            && viewportGLWidget == painter->device()) {

I would put those test as the first statements of the functions, and return if not true.

That way it is clear, if the initial condition are not correct, just return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.