[Webkit-unassigned] [Bug 56076] rebaseline-chromium-webkit-tests should ignore reftests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56076





--- Comment #9 from Hayato Ito <hayato at chromium.org>  2011-03-16 21:06:38 PST ---
Thank you for the review.

(In reply to comment #7)
> (From update of attachment 85902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85902&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:256
> > +                self._rebaselining_tests = []
> 
> If you return like this, then Rebaseliner.run() will return True (success), and we won't think the rebaselining failed, which is probably not what we want to happen.
> 
> I think you either need to change this to raise an Exception or modify the return value to a three-state thing (no tests to rebaseline, error, or proceed).
> 
> Otherwise, the patch looks fine.

That's good point.

I've updated the patch so that we can distinguish 'no-tests' and 'reftest-error' in a slightly different way from your suggestion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.