[Webkit-unassigned] [Bug 54443] Textarea maxlength doesn't account for newlines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54443





--- Comment #39 from Naoki Takano <takano.naoki at gmail.com>  2011-03-16 19:51:17 PST ---
According to http://www.chromium.org/developers/testing/webkit-layout-tests#TOC-Running-the-Tests
 ./webkit/tools/layout_tests/run_webkit_tests.sh
looks correct.

But, do you mean
Tools/Scripts/run-webkit-tests
is correct?

I didn't know there are two version of run-webkit-tests or run_webkit_tests.

Which is correct one?

(In reply to comment #38)
> (In reply to comment #37)
> > While I'm looking around the test code, I noticed textarea-maxlength-expected.txt doesn't affect the test output.
> 
> You mean "doesn't get affected"?
> 
> > As you know, if we really need expectation check, we have to add the test into test_expectations.txt, right?
> 
> No.  Every test that doesn't have an entry in test_expectations.txt will be ran and the results are compared against the expected result.  So not having an entry means that we expect the test to run normally and its output to match the expected result.
> 
> > But textarea-maxlength.html doesn't exist in test_expectations.txt. I guess run_webkit_tests checks the test output strings and confirms "PASS" or "FAIL".
> 
> I don't think so.  Your patch should have changed in http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/textarea-maxlength-expected.txt as in http://trac.webkit.org/changeset/48903
> 
> > I confirmed the following cases,
> > 1, Even if I change textarea-maxlength-expected.txt, the test passes. So the file doesn't affect anything. Also I delete it, still the test passes.
> 
> That doesn't make any sense.  You're probably not running it correctly.  Did you rebuild WebKit before running LayoutTests?
> 
> > 2, If I change textarea-maxlength.html in order to fail the test intentionally, it fails.
> > 3, Even if I try to generate new-baseline with --new-baseline option, I cannot change textarea-maxlength-expected.txt.
> 
> Which port are you using to do this?  You should be running Tools/Scripts/run-webkit-tests (optionally --debug if you're using debug build) and I don't think it has --new-baseline option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.