[Webkit-unassigned] [Bug 54443] Textarea maxlength doesn't account for newlines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54443





--- Comment #37 from Naoki Takano <takano.naoki at gmail.com>  2011-03-16 19:29:47 PST ---
Niwa-san,

While I'm looking around the test code, I noticed textarea-maxlength-expected.txt doesn't affect the test output.

As you know, if we really need expectation check, we have to add the test into test_expectations.txt, right?
http://www.chromium.org/developers/testing/webkit-layout-tests#TOC-Test-Expectations

But textarea-maxlength.html doesn't exist in test_expectations.txt. I guess run_webkit_tests checks the test output strings and confirms "PASS" or "FAIL".

I confirmed the following cases,
1, Even if I change textarea-maxlength-expected.txt, the test passes. So the file doesn't affect anything. Also I delete it, still the test passes.
2, If I change textarea-maxlength.html in order to fail the test intentionally, it fails.
3, Even if I try to generate new-baseline with --new-baseline option, I cannot change textarea-maxlength-expected.txt.

What do you think?

(In reply to comment #36)
> Hmm...
> 
> My git repo looks strange;-(
> 
> Even if "git diff", it cannot detect expected.txt diff.
> 
> I'll take all the repo again, and make the patch later...
> 
> Thanks,
> 
> (In reply to comment #35)
> > (From update of attachment 85914 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=85914&action=review
> > 
> > > LayoutTests/fast/forms/script-tests/textarea-maxlength.js:95
> > > +shouldBe('textArea.value', '"a\\n\\n"');
> > 
> > I'm a bit confused.  Why am I not seeing changes in textarea-maxlength-expected.txt ?  Aren't these changed suppose to affect the test ouput?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.