[Webkit-unassigned] [Bug 56514] [chromium] Properly reset VideoLayerChromium textures after lost renderer context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56514





--- Comment #3 from Victoria Kirst <vrk at chromium.org>  2011-03-16 19:24:36 PST ---
(In reply to comment #2)
> (From update of attachment 86017 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86017&action=review
> 
> > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:96
> > +    if (replacingRenderer)
> > +        resetFrameParameters();
> 
> LayerChromium::setLayerRenderer() will call cleanupResources() if (layerRenderer() && layerRenderer() != renderer), which will call releaseCurrentFrame() which contains a call to resetFrameParameters(). Doesn't that make this override redundant?

Good question! It's not redundant because m_currentFrame can be null, and in that case releaseCurrentFrame() will not call resetFrameParameters() because it exits out early.

And actually, saveCurrentFrame/releaseCurrentFrame are hooks to be used when we have hardware decoding implemented in Chrome. Right now we don't have hardware decode implemented, so m_currentFrame is _always_ null.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.