[Webkit-unassigned] [Bug 56439] Get rid of nearestMailBlockquote

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56439





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-16 15:33:01 PST ---
(From update of attachment 85984)
View in context: https://bugs.webkit.org/attachment.cgi?id=85984&action=review

>> Source/WebCore/editing/htmlediting.h:118
>> +    return node && editingIgnoresContent(node) ? positionBeforeNode(node) : firstPositionInNode(node);
> 
> This doesn't look right.  && has precedence over ?, so if |node| is NULL, we return firstPositionInNode(NULL).  That seems safe, but in lastPositionInOrAfterNode, we return lastPositionInNode(NULL), which calls lastOffsetInNode(NULL), which will try to dereference NULL.

Ah that's a good point.  I should just do "!node ||"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.