[Webkit-unassigned] [Bug 55859] [Chromium] The method that retrieves all resources from a page should be moved from Chromium to WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 16 14:44:53 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55859


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85970|review?                     |review-
               Flag|                            |




--- Comment #19 from David Levin <levin at chromium.org>  2011-03-16 14:44:53 PST ---
(From update of attachment 85970)
View in context: https://bugs.webkit.org/attachment.cgi?id=85970&action=review

r- because I want Vector::contains :)

> Source/WebKit/chromium/src/WebPageSerializer.cpp:61
> +{

ASSERT(element);

> Source/WebKit/chromium/src/WebPageSerializer.cpp:63
> +    if (element->hasTagName(HTMLNames::imgTag) || element->hasTagName(HTMLNames::scriptTag)) {

Style bot missed this one but it is still true: "One line control clauses should not use braces.  [whitespace/braces] [4]"

> Source/WebKit/chromium/src/WebPageSerializer.cpp:65
> +    } else if (element->hasTagName(HTMLNames::inputTag)) {

Leave the braces for this if.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:72
> +               || element->hasTagName(HTMLNames::tdTag)) {

Remove them here.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:77
> +               || element->hasTagName(HTMLNames::insTag)) {

Remove them here.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:79
> +    } else if (element->hasTagName(HTMLNames::linkTag)) {

Leave the braces for this if.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:86
> +    } else if (element->hasTagName(HTMLNames::objectTag)) {

Remove them here.

>> Source/WebKit/chromium/src/WebPageSerializer.cpp:90
>> +    }
> 
> One line control clauses should not use braces.  [whitespace/braces] [4]

What Style bot said.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:115
> +            if (visitedFrames->find(frame) == notFound)

May I recommend adding contains to Vector (just implement in terms of find)?

> Source/WebKit/chromium/src/WebPageSerializer.cpp:130
> +    if (resourceURLs->find(url) == notFound)

Use contains.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:159
> +    if (visitedFrames->find(frame) != notFound)

Use contains.

> Source/WebKit/chromium/src/WebPageSerializer.cpp:162
> +    if (frameURLs->find(frameURL) == notFound)

Use contains.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list